Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cause of Death List Tidying #67

Open
jmotis opened this issue Mar 14, 2023 · 2 comments
Open

Cause of Death List Tidying #67

jmotis opened this issue Mar 14, 2023 · 2 comments

Comments

@jmotis
Copy link
Contributor

jmotis commented Mar 14, 2023

"Found dead" and "Found Dead" should be merged as causes of death; similarly "Other Casualties" and "Other" probably should be merged but you should double-check that one.

@hepplerj hepplerj self-assigned this Mar 14, 2023
@hepplerj
Copy link
Member

Is this the kind of thing worth trying to catch before an export leaves DataScribe, or do we want to make it part of the general data tidying that happens post-export?

If we go with post-export cleaning, the easiest here might be to just have the data tidying script lowercase everything so we get just the distinct values. That would mean everything in the filtering panes on the website would likewise be lowercase instead of title case as it is now (although . Same with "Other" vs "Other Casualties," although in that case the script would have to do some string replacement. Either way works for me.

@jmotis
Copy link
Contributor Author

jmotis commented Mar 15, 2023

Looking at the data csvs, it seems like the "Found d/Dead" issue may have been baked into the BOM Form (one uppercase - Laxton regular; one lowercase - Laxton 1700; one rogue - Wellcome weekly bills where we didn't do it as a separate form field). The Other/Other Casualties might also be from the Wellcome bills. If we can just manually update what's on the site now, I can fix future exports.

@jmotis jmotis self-assigned this Sep 18, 2024
@jmotis jmotis mentioned this issue Sep 25, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants