Initial ground work to switch to using Chocolatey.Cake.Recipe #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an initial stab at switching this repository over to use Chocolatey.Cake.Recipe, as well as to switch to using the new csproj format (to allow compiling for .NET Standard 2.0). The thought process here was that since this is a library, and we are targetting at a monimum going forward .NET 4.8, that is would make sense to set the project up to be more easily cross-compiled to different target frameworks when required. The reason that this work was halted was due to the fact that the current tests require an API key in order to run, and as a result, they run into problems with a key that only allows 4 requests per hour. For now, going to halt work on this, until we decide how we want to proceed, i.e. either to re-write the tests to _not_ rely on an API Key, or use a different key that doesn't have the same limitations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an initial stab at switching this repository over to use Chocolatey.Cake.Recipe, as well as to switch to using the new csproj format (to allow compiling for .NET Standard 2.0). The thought process here was that since this is a library, and we are targetting at a monimum going forward .NET 4.8, that is would make sense to set the project up to be more easily cross-compiled to different target frameworks when required.
The reason that this work was halted was due to the fact that the current tests require an API key in order to run, and as a result, they run into problems with a key that only allows 4 requests per hour.
For now, going to halt work on this, until we decide how we want to proceed, i.e. either to re-write the tests to not rely on an API Key, or use a different key that doesn't have the same limitations.