(#3465) Allow building an MSI during outside of tagged commits. #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corbob
force-pushed
the
build-msi
branch
2 times, most recently
from
8c9dbed
to
c8151ad
Compare
|
Edit: This is resolved by having the GitHub Action also pick up the MSI and include it with the artifacts. |
corbob
commented
Jun 15, 2024
corbob
force-pushed
the
build-msi
branch
3 times, most recently
from
730a712
to
0495a4f
Compare
|
I have added a commit onto this PR that fixes up the Arguments decryption tests for the Download command. |
vexx32
previously requested changes
Nov 19, 2024
Prepare-Chocolatey-Package previously would fail if not run as part of a target that also included copying the nuspec files. This commit makes the task dependency explicit so you can directly run Prepare-Chocolatey-Package.
Changed the logic for skipping an MSI build to skip it by default, and no longer depend on a tagged build. This will allow developers to generate an MSI by adding `--shouldBuildMsi=true`.
When running the builds in CI, we should generate the MSI as well. This will allow us to get an MSI for any build to test with if needed.
As with the previous commit, this adds the configuration for GitHub Actions. Thus allowing us to ensure the MSI is able to be built in GitHub Actions as well. When running the builds in CI, we should generate the MSI as well. This will allow us to get an MSI for any build to test with if needed.
When the tests are run against the download command, the second run was failing due to already having downloaded the package. Remove the download directory to ensure the tests function the same.
|
@corbob thank you for getting this fixed up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Update the Recipe used to default to not build an MSI. Update the CI configurations to allow building the MSI with the addition of the
--shouldBuildMsi=trueparameter.Motivation and Context
Ease the experience of making adjustments to the MSI. Allow us to get an MSI more regularly for testing.
Testing
./build.bat --target=Build-Msi./build.bat --target=Build-Msi --shouldBuildMsi=truecode_drop/Artifactsandcode_drop/MSIs/en-USdirectories to confirm that an MSI was generated.Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #3465