Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

Welcome message only adapts when query/discover page is loaded directly #753

Open
bruth opened this issue Dec 28, 2014 · 1 comment
Open

Comments

@bruth
Copy link
Contributor

bruth commented Dec 28, 2014

It appears to be working due to this line, but if it's navigated to after the fact, the change event does not fire (until the context is changed). The onRender method should be implemented that calls renderWelcomeMessage to ensure it's displays after the context has loaded.

@bruth
Copy link
Contributor Author

bruth commented Dec 28, 2014

The implementation assumes that having one filter applied denotes an existing user. However if the filters are cleared the message reverts to the "new user" message which makes this method not reliable.

Ideally, the API would provide an endpoint that provides information about the session including:

  • info about the user (if this is an authenticated session)
  • session start time

For non-authenticated users, the session start time could be used to determine whether the "new user" method should be shown. If authenticated, the join date and last login time could be used to toggle the message.

Until session-based information is available there is not a reliable fix for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant