Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field in models.csv to declare base model #34

Open
bruth opened this issue May 27, 2015 · 3 comments
Open

Add field in models.csv to declare base model #34

bruth opened this issue May 27, 2015 · 3 comments
Labels

Comments

@bruth
Copy link
Contributor

bruth commented May 27, 2015

This may be a bit too specific to our use case, but declaring the base model could help to infer some things. For example, the PEDSnet data model is based on OMOP so we could rely on that for implicit mappings and add a file type to declare the diff from the base model (rather than redefining all the fields).

@bruth bruth added the question label May 27, 2015
@gracebrownecodes
Copy link
Contributor

I suppose this would make sense, especially if we want to support the addition of data models by other parties. But I worry about violating WYSIWYG.

@bruth
Copy link
Contributor Author

bruth commented Jun 12, 2015

But I worry about violating WYSIWYG.

I generally agree with this. A more practical application would be to create a tool that copies an existing data model, increments the version across all the files and sets up the default mappings. For example, if you did data-models derive pedsnet/v1 omop/v4 it would copy all the files in omop/v4 and replace all the instances of model and version with pedsnet and v1 and add additional mappings between omop/v4 and pedsnet/v1.

@gracebrownecodes
Copy link
Contributor

👍

@bruth bruth changed the title Add field in datamodel.json to declare base model Add field in models.csv to declare base model Jun 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants