-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace additional characters #11
Comments
Hmm, github isn't letting me upload my patch file, so I'll upload it as a txt. |
@randoogle Thanks for the contribution. I've been meaning to update the dependencies for this extension, so I can integrate your changes at the same time. Honestly it will probably be a few weeks .... |
Yeah, I noticed there were some outdated dependency issues during the install/compile process. |
@murphyke "Honestly it will probably be a few weeks..." so, how's the patch coming? Any plans to use the @randoogle patch? |
I often have to maintain json that gets exported from another third-party application. In addition to new lines "\n" it also include carriage returns "\r" (in a windows style line ending I guess).
Some of the code also includes tabs "\t" and of course double-quotes \"
I've gone ahead and made the changes on my end and re-built the extension, and it's working great now.
I know there's probably other characters that might need to be included, but I feel like I've covered the most of the use cases.
The text was updated successfully, but these errors were encountered: