Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ROS 1/2 in this repository #17

Closed
wants to merge 46 commits into from
Closed

Support ROS 1/2 in this repository #17

wants to merge 46 commits into from

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Dec 2, 2023

TBD...

HansRobo added 30 commits October 13, 2021 01:15
@HansRobo
Replace "ROS" with "ROS2"
40c3f0c
@HansRobo
Replace "ROS" with "ROS2"
b1a7c56
@HansRobo
Migrate ROSPlugin.cpp from ROS to ROS2
8a0dd3f
@HansRobo
Migrate build system from catkin to ament
9870a84
@HansRobo
Migrate choreonoid_ros from ROS to ROS2
5515bfb
@HansRobo
Migrate BodyROSItem from ROS to ROS2 (WIP)
4f2d1c8
@HansRobo
Fix compile errors in BodyROS2Item.cpp
90fea43
@HansRobo
Fix implementation
33b79bd
@HansRobo
WIP
3af8ab2
@HansRobo
Stopped inheriting rclcpp::Node and transferred it
fb60fb1
@HansRobo
Replace ImageTransport::Publisher with rclcpp::Publisher
b932b61
@HansRobo
Apply linter & delete unused debug message
02b11ef
@HansRobo
Format
4037e29
@HansRobo
Format
fda1aec
@HansRobo
Apply clang-format
32646fa
@HansRobo
Update ROS2 plugin path
86d4e96
@HansRobo
Add build test
f721150
@HansRobo
Add pullrequest trigger for build test
183af3e
@HansRobo
Use curl action in build test
05b0952
@HansRobo
Fix build_test.yaml
5d37602
@HansRobo
Fix script path in build_test.yaml
5677e05
@HansRobo
Change way to download script in build_test.yaml
8e58fae
@HansRobo
Use shinhwagk/remote-bash to execute script in build_test.yaml
d0f7252
@HansRobo
Stop using script in build_test.yaml
ad824ce
@HansRobo
Merge pull request #1 from choreonoid/feature/github_ci
71872e7 
Add GitHub Actios workflow for build error checking
@HansRobo
Change PROJECT_NAME
26ec0bf
@HansRobo
Use image_transport to publish images (#2)
df50a60 
* Replace image publishers with ones in image_transport

* Fix loading plugin name

* Delete debug messages

* Delete unused code
@HansRobo
Support ROS 2 Humble (#4)
84222c4 
* Fix library install destination

* Set include directories in CMakeLists.txt

* Use generalized plugin path for app

* Delete duplicated-instanciated plugin

* Update ros2 to humble in build test workflow

* Update build dependencies (ref: latest install-requisites-ubuntu-22.04.sh)

* Do apt update/upgrade in build workflow

* Use osrf/ros:humble-desktop-jammy as build workflow base image

* Update ros-tooling/action-ros-ci

* Add libzip-dev to install dependencies

* Fix plugin/CMakeLists.txt

* Clean up build test workflow

* Skip test on build test workflow

* Add python3-colcon-lcov-result / python3-colcon-coveragepy-result to dependencies
@HansRobo
Merge remote-tracking branch 'origin/ros2-dev' into feature/ros2
aaa3779 
# Conflicts:
#	CMakeLists.txt
#	package.xml
#	src/node/choreonoid_ros.cpp
#	src/plugin/BodyROSItem.cpp
#	src/plugin/BodyROSItem.h
#	src/plugin/CMakeLists.txt
#	src/plugin/ROSPlugin.cpp
@HansRobo
Switch dependencies by ROS version in package.xml
7df6989
@HansRobo HansRobo requested a review from ssr-yuki December 2, 2023 02:23
@HansRobo
Copy link
Member Author

HansRobo commented Dec 3, 2023 •
edited
Loading

TODOs

  • delete unnessesary diffs (e.g. src/plugin/pybind11/PyROSPlugin.cpp)
  • fix build test error
  • modify files in deprecated directory to support both of ROS 1/2

@HansRobo
Copy link
Member Author

HansRobo commented Mar 2, 2024

Close with #18

@HansRobo HansRobo closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssr-yuki ssr-yuki Awaiting requested review from ssr-yuki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HansRobo @s-nakaoka