Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BodyROS2] Use joint names for joint states surely #20

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

ssr-yuki
Copy link
Member

This PR fixes joint names used in joint states.

Note that name() function returns not the joint name but the link name in general.

@ssr-yuki ssr-yuki requested a review from HansRobo March 17, 2024 18:21
@ssr-yuki ssr-yuki self-assigned this Mar 17, 2024
Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
The changes are same to 01cf35f for ROS 1.

@ssr-yuki
Copy link
Member Author

The changes are same to 01cf35f for ROS 1.

Exactly. Thank you for the supplementary explanation.

@ssr-yuki ssr-yuki merged commit c2d039f into master Mar 19, 2024
1 check passed
@ssr-yuki ssr-yuki deleted the hotfix/BodyROS2/joint_names branch March 19, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants