Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a custom implementation of an extensible point #18

Open
leonardofl opened this issue Jan 8, 2013 · 2 comments
Open

Selecting a custom implementation of an extensible point #18

leonardofl opened this issue Jan 8, 2013 · 2 comments

Comments

@leonardofl
Copy link
Member

Currently the user can write a new CloudProvider or NodeSelector.
But if he write the name of his custom class in the properties file, DeploymentManager will not be able to select his class.
We must enable it.
We must also ensure the user can use his own custom ContextSender and RecipeBuilder.

@leonardofl
Copy link
Member Author

Obs: Since ServiceType and ArtifactType are intended to be extended,
they cannot be simple enums.
Solution (by Carlos Moraes): to use the type safe enum pattern.
Create a class ServiceType, that has a private constructor
and initializes a set of instances based on a config file.
Default values can have constants pointing to them (e.g. SOAP = new ServiceType('SOAP')),
but to access non-defualt values it is necessary something like
ServiceType.getInstanceByName("JMS").

leonardofl added a commit that referenced this issue May 22, 2013
@leonardofl
Copy link
Member Author

Done to NodeSelector: 18d67dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant