Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider moving plugin validation to BasePlugin constructor #504

Open
chris48s opened this issue Sep 8, 2024 · 1 comment
Open

consider moving plugin validation to BasePlugin constructor #504

chris48s opened this issue Sep 8, 2024 · 1 comment

Comments

@chris48s
Copy link
Owner

chris48s commented Sep 8, 2024

At the moment, there's a stand-alone validatePlugin() method which is called on each plugin as v8r loads them. Would it make more sense to move that to BasePlugin.constructor() ? I think that would improve the process of developing plugins that live in their own repo as you can easily ensure your plugin passes validation checks in the plugin's test suite.

@chris48s
Copy link
Owner Author

A possible problem with this would be that plugins could override the validation, which would be bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant