From 9f55acd77c2569831965b2d63ca9dcb2b6823f62 Mon Sep 17 00:00:00 2001 From: christianrowlands Date: Fri, 12 Apr 2024 08:01:26 -0400 Subject: [PATCH] Fix the NARFCN label to include Band: "NARFCN/Band" Also set the minimum signal bar to 5% to make sure there is something there when the signal is low --- .../networksurvey/fragments/NetworkDetailsFragment.java | 6 +++--- networksurvey/src/main/res/values/strings.xml | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/networksurvey/src/main/java/com/craxiom/networksurvey/fragments/NetworkDetailsFragment.java b/networksurvey/src/main/java/com/craxiom/networksurvey/fragments/NetworkDetailsFragment.java index 49f30878..9e3a9faa 100644 --- a/networksurvey/src/main/java/com/craxiom/networksurvey/fragments/NetworkDetailsFragment.java +++ b/networksurvey/src/main/java/com/craxiom/networksurvey/fragments/NetworkDetailsFragment.java @@ -532,7 +532,7 @@ private void updateServingCellProtocol(CellularProtocol protocol) binding.tacLabel.setText(R.string.tac_label); binding.enbIdGroup.setVisibility(View.GONE); binding.sectorIdGroup.setVisibility(View.GONE); - binding.earfcnLabel.setText(R.string.narfcn_label); + binding.earfcnLabel.setText(R.string.narfcn_band_label); binding.pciLabel.setText(R.string.pci_label); binding.bandwidthGroup.setVisibility(View.GONE); binding.taGroup.setVisibility(View.GONE); @@ -999,8 +999,8 @@ private void setSignalStrengthBar(RoundedProgressBar signalStrengthBar, Integer signalStrengthBar.setProgressDrawableColor(color); signalStrengthBar.setBackgroundColor(ColorUtils.getFadedColor(color)); - // We want there to be at least a small amount of the bar visible, so we set the minimum to 2%. - signalStrengthBar.setProgressPercentage(Math.max(2, scaledNormalizedValue), true); + // We want there to be at least a small amount of the bar visible, so we set the minimum to 5%. + signalStrengthBar.setProgressPercentage(Math.max(5, scaledNormalizedValue), true); } /** diff --git a/networksurvey/src/main/res/values/strings.xml b/networksurvey/src/main/res/values/strings.xml index 30da8ca0..d5a71062 100644 --- a/networksurvey/src/main/res/values/strings.xml +++ b/networksurvey/src/main/res/values/strings.xml @@ -117,6 +117,7 @@ but work independently, so you have full control over how you handle your data.< %1$s dB + NARFCN/Band NARFCN SS_RSRP SS_RSRQ