Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a finalize command for monorepos #1150

Open
rhuanbarreto opened this issue Feb 6, 2025 · 0 comments
Open

Support a finalize command for monorepos #1150

rhuanbarreto opened this issue Feb 6, 2025 · 0 comments

Comments

@rhuanbarreto
Copy link

Feature request

In monorepos, Chromatic generates lots of status checks for each project. But I can't setup in github to wait for all status checks to be green to allow the PR to be merged.

Proposed solution

LostPixel came with a good solution: https://docs.lost-pixel.com/user-docs/recipes/lost-pixel-platform/monorepo

It's a FINALIZE command that triggers the cloud service and the cloud service generates one status check that gets updated whenever all the other ones are green. This status check can be added to the list of required status checks for merging.

Alternative solutions

Today there are some alternatives:

  • Run Chromatic with exitOnceUploaded: false and wait until the command fails or passes. This has a big CI cost for us because we need to wait for Chromatic response.
  • Manually waiting for all status checks to pass before giving an approval. Not practical in monorepos as every contributor must know this rule (this is actually what we do today)
  • Using workflows like wait-for-checks which incur in CI cost for polling github
@rhuanbarreto rhuanbarreto added CLI needs triage Tracking: Issue needs confirmation labels Feb 6, 2025
@linear linear bot added Feature and removed needs triage Tracking: Issue needs confirmation labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant