Skip to content

Commit

Permalink
Fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
GrahamCampbell committed Nov 6, 2024
1 parent 9af2a5a commit c8c087e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions tests/BrowserFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,15 @@ public function testConnectToBrowser(): void

// TODO test existing pages propagation

// create a new connectionn to the existing browser
// create a new connection to the existing browser
$browser2 = BrowserFactory::connectToBrowser($browser->getSocketUri());

// create a page on the first browser after 2d connection
// create a page on the first browser after 2nd connection
$page2 = $browser->createPage();
sleep(1);
$page2TargetId = $page2->getSession()->getTargetId();

// update 2d browser
// update 2nd browser
$browser2->getConnection()->readData();

// make sure 2nd browser received the new page
Expand Down
2 changes: 1 addition & 1 deletion tests/BrowsingTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public function testGetPagesClose(): void

$page->close();

usleep(250000);
sleep(1);

$finalCount = \count(self::$browser->getPages());

Expand Down

0 comments on commit c8c087e

Please sign in to comment.