Allow usage of XPathSelector in Page::waitForElement

[jhoopmann]

chrome/src/Page.php

Line 483 in f9fcb66

$element = Utils::getElementPositionFromPage($this, new CssSelector($selectors), $position);

#531 (comment)

It's always using CssSelector.

It should be possible to pass an instance of a custom selector.

   /**
     * Wait until page contains Node.
     *
     * @param string|Selector $selectors
     * @param int $timeout = 30000
     * @throws Exception\OperationTimedOut
     */
    public function waitUntilContainsElement($selectors, int $timeout = 30000): self
    {
        $this->assertNotClosed();

        Utils::tryWithTimeout($timeout * 1000, $this->waitForElement($selectors));

        return $this;
    }

    /**
     * @param string|Selector $selectors
     * @param int $position = 1
     * @return bool|\Generator
     *
     * @internal
     */
    public function waitForElement($selectors, int $position = 1)
    {
        if (!($selectors instanceof Selector)) {
            $selectors = new CssSelector($selectors);
        }

        $delay = 500;
        $element = [];

        while (true) {
            try {
                $element = Utils::getElementPositionFromPage($this, $selectors, $position);
            } catch (JavascriptException $exception) {
                yield $delay;
            }

            if (\array_key_exists('x', $element)) {
                return true;
            }

            yield $delay;
        }
    }

[enricodias]

The code looks good. Can you open a PR with this change?
We also need to update the docs and add a test for that feature.

[jhoopmann]

The code looks good. Can you open a PR with this change? We also need to update the docs and add a test for that feature.

Apologies for the delayed response. I've opened a pull request and hope the changes are okay so far.

[stale]

This issue has been automatically marked as stale because there has been no recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions.