Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate usage of the Date<Tz> type #851

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Deprecate usage of the Date<Tz> type #851

merged 4 commits into from
Nov 9, 2022

Conversation

djc
Copy link
Member

@djc djc commented Oct 20, 2022

Recommend reviewing per commit.

@djc djc requested a review from esheppa October 20, 2022 10:41
esheppa
esheppa reviewed Oct 20, 2022
View reviewed changes
src/naive/date.rs Outdated Show resolved Hide resolved
esheppa
esheppa reviewed Oct 20, 2022
View reviewed changes
src/offset/mod.rs Outdated Show resolved Hide resolved
@djc djc mentioned this pull request Oct 24, 2022
Closed
@djc djc requested a review from esheppa October 24, 2022 12:07
esheppa
esheppa reviewed Oct 31, 2022
View reviewed changes
src/naive/date.rs Outdated Show resolved Hide resolved
esheppa
esheppa reviewed Oct 31, 2022
View reviewed changes
src/datetime/mod.rs Outdated Show resolved Hide resolved
esheppa
esheppa approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@esheppa esheppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - excited to get this merged!

@djc djc requested a review from esheppa November 4, 2022 21:50
@djc
Copy link
Member Author

djc commented Nov 9, 2022

(CI failures are unrelated, fixed in #863.)

djc added 4 commits November 9, 2022 13:24
@djc
Move Date::years_since() implementation into NaiveDate
b3e8cce
@djc
Add TimeZone::with_ymd_and_hms() helper method
430cd49 
We don't add `with_yo_and_hms()` and `with_isoywd_and_hms()` here,
instead recommending users can use `from_local_datetime()` with
a separately constructed `NaiveDateTime`.
@djc
Deprecate usage of the Date<Tz> type
c8a0d69
@djc
Avoid use of deprecated API
57cd4ef
@djc djc merged commit 22b4d32 into 0.4.x Nov 9, 2022
@djc djc deleted the no-date-tz branch November 9, 2022 12:37
@dtolnay dtolnay mentioned this pull request Nov 13, 2022
Open
@Ten0
Copy link

Ten0 commented Nov 13, 2022

no issue reference with rationale?

@esheppa
Copy link
Collaborator

esheppa commented Nov 13, 2022

Hi @Ten0 - please see the discussion in #820 - if you have some code examples of use of Date<Tz> that would be greatly appreciated

@Ten0
Copy link

Ten0 commented Nov 13, 2022 •
edited
Loading

Hi! thanks a lot :)
I'm reasonably happy with that change, I just wanted to read the thinking around it out of curiosity 😊

@ryoqun ryoqun mentioned this pull request Jan 14, 2023
Merged
@pitdicker pitdicker mentioned this pull request Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esheppa esheppa esheppa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @Ten0 @esheppa