Skip to content
This repository has been archived by the owner on Jul 16, 2020. It is now read-only.

ciao-launcher needs some unit tests #1

Open
markdryan opened this issue Apr 7, 2016 · 0 comments
Open

ciao-launcher needs some unit tests #1

markdryan opened this issue Apr 7, 2016 · 0 comments
Assignees
@markdryan
Labels
ciao-launcher enhancement P2

Comments

@markdryan
Copy link
Contributor

markdryan commented Apr 7, 2016 •
edited by amyleeland
Loading

Its one existing test cases only covers 6.2 % of the code. We need to get this up to at least 70%.
@markdryan markdryan self-assigned this Apr 7, 2016
@chavafg chavafg mentioned this issue Apr 15, 2016
Closed
@amyleeland amyleeland added this to the Sprint 1.0 milestone Jun 2, 2016
@markdryan markdryan added the P1 label Jun 6, 2016
markdryan pushed a commit to markdryan/ciao that referenced this issue Jun 7, 2016
ciao-launcher: Add unit tests for the overseer.
e0f4991 
This commit adds some unit tests for the overseer go routine.  It
partially implements Issue ciao-project#1.

Signed-off-by: Mark Ryan <[email protected]>
markdryan pushed a commit to markdryan/ciao that referenced this issue Jun 8, 2016
ciao-launcher: Add unit tests for the overseer.
0596ad7 
This commit adds some unit tests for the overseer go routine.  It
partially implements Issue ciao-project#1.

Signed-off-by: Mark Ryan <[email protected]>
markdryan pushed a commit to markdryan/ciao that referenced this issue Jun 8, 2016
ciao-launcher: Add unit tests for the overseer.
6471212 
This commit adds some unit tests for the overseer go routine.  It
partially implements Issue ciao-project#1.

Signed-off-by: Mark Ryan <[email protected]>
@albertomurillo albertomurillo mentioned this issue Jun 22, 2016
Merged
markdryan pushed a commit to markdryan/ciao that referenced this issue Jul 18, 2016
ciao-launcher: Add TestExtractImageInfo
c88d0ef 
Add a new unit test case to test the code that extracts information from
qemu-img info.

Partial fix for issue ciao-project#1

Signed-off-by: Mark Ryan <[email protected]>
markdryan pushed a commit to markdryan/ciao that referenced this issue Jul 18, 2016
ciao-launcher: Add TestGenerateQEMULaunchParams
a8d0b08 
Add a new unit test case to test the code that generates qemu launch
parameters.

Partial fix for issue ciao-project#1

Signed-off-by: Mark Ryan <[email protected]>
markdryan pushed a commit to markdryan/ciao that referenced this issue Jul 18, 2016
ciao-launcher: Add unit tests for the qmp go routines
4583c0e 
This commit adds four unit tests

- TestQmpConnectBadSocket
- TestQmpLost
- TestQmpShutdown
- TestQmpConnect

It is a partial fix for issue ciao-project#1

Signed-off-by: Mark Ryan <[email protected]>
@kaccardi kaccardi mentioned this issue Aug 11, 2016
Merged
tpepper referenced this issue in tpepper/ciao Aug 23, 2016
@ikeydoherty
Merge pull request #1 from tpepper/prepare
a9af65a 
Prepare: a few tweeks
@amyleeland amyleeland removed this from the Sprint 1 milestone Sep 6, 2016
@albertomurillo albertomurillo mentioned this issue Sep 9, 2016
Merged
@amyleeland amyleeland added this to the Sprint 4 milestone Oct 17, 2016
@kaccardi kaccardi removed this from the Sprint 4 milestone Dec 16, 2016
markdryan pushed a commit to markdryan/ciao that referenced this issue Jan 5, 2017
ciao-launcher: Add more docker unit tests
b5dc87c 
This commit adds the following new docker unit tests:

- TestDockerCreateImageFail
- TestDockerCreateImageWithVolumes
- TestDockerCreateImageWithResources
- TestDockerMonitorVM
- TestDockerMonitorVMClose
- TestDockerStats

It improves launcher's unit test coverage to 52.6%.

Partial fix for issue ciao-project#1

Signed-off-by: Mark Ryan <[email protected]>
markdryan pushed a commit to markdryan/ciao that referenced this issue Jan 5, 2017
ciao-launcher: Add more docker unit tests
892b877 
This commit adds the following new docker unit tests:

- TestDockerCreateImageFail
- TestDockerCreateImageWithVolumes
- TestDockerCreateImageWithResources
- TestDockerMonitorVM
- TestDockerMonitorVMClose
- TestDockerStats

It improves launcher's unit test coverage to 52.6%.

Partial fix for issue ciao-project#1

Signed-off-by: Mark Ryan <[email protected]>
@markdryan markdryan mentioned this issue Jan 5, 2017
Merged
@kaccardi kaccardi added P2 and removed P1 labels Jan 19, 2017
@amyleeland amyleeland removed the ready label Feb 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markdryan markdryan

Labels
ciao-launcher enhancement P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@markdryan @amyleeland @kaccardi