Skip to content
This repository has been archived by the owner on Jul 16, 2020. It is now read-only.

switch ssntp payload from yaml to json for marshall/unmarshall #85

Open
kaccardi opened this issue May 2, 2016 · 3 comments
Open

switch ssntp payload from yaml to json for marshall/unmarshall #85

kaccardi opened this issue May 2, 2016 · 3 comments

Comments

@kaccardi
Copy link
Contributor

kaccardi commented May 2, 2016

The yaml parser is much slower than the json parser. Switching our ssntp payload to be json rather than yaml will cut the marshal/unmarshal time in half.

@tpepper
Copy link

tpepper commented May 24, 2016

I wonder if this should be tagged "enhancement" versus eg: "technical debt cleanup"

@kaccardi kaccardi added the P2 label Jun 6, 2016
@amyleeland amyleeland added this to the Sprint 2 milestone Jun 9, 2016
@tpepper tpepper modified the milestones: Sprint 3, Sprint 2 Jul 19, 2016
@amyleeland amyleeland removed this from the Sprint 3 milestone Sep 6, 2016
@tpepper
Copy link

tpepper commented Sep 6, 2016

I've added the "janitorial" label on this. It's a modestly complex effort from an integration / validation standpoint, but in terms of code complexity and requisite initial skill to accomplish it should be a good starting point for a new contributor.

@markdryan
Copy link
Contributor

Have we definitely agreed that it's a good idea to do this? IIRC the yaml parsing was slow but it wasn't on the critical path. Moving to json would make things less readable. Perhaps we could try to speed up the yaml parser.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants