Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate cisagov/ansible-role-pip into this role #51

Open
3 tasks
mcdonnnj opened this issue Dec 12, 2022 · 0 comments
Open
3 tasks

Consolidate cisagov/ansible-role-pip into this role #51

mcdonnnj opened this issue Dec 12, 2022 · 0 comments
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@mcdonnnj
Copy link
Member

💡 Summary

We should consolidate cisagov/ansible-role-pip's functionality into this role by incorporating it as install_pip/install_pip2 role variables.

Motivation and context

Currently if one uses the cisagov/ansible-role-pip role you will get Python packages due to dependencies on the system pip packages. This can lead to inconsistent package installations if both roles are not used and also causes an overlap in functionality. Since pip is a "core" Python package it also makes sense logistically to incorporate its installation into this role.

Implementation notes

A sample use would be:

- hosts: all
  become: yes
  become_method: sudo
  tasks:
    - name: Include python
      ansible.builtin.include_role:
        name: python
        vars:
          install_pip: true

Acceptance criteria

How do we know when this work is done?

  • Installing pip2/pip3 is incorporated into this role using role variables.
  • Downstream repositories using cisagov/ansible-role-pip are updated to use this role with appropriate role variables.
  • The cisagov/ansible-role-pip repository is archived.
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

No branches or pull requests

1 participant