-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
safetensors do not appear in Load Diffusion Model node while the models already in unet folder #179
Comments
I just had this exact issue. After I uninstalled the ComfyUI-Flow-Control custom node, everything worked properly again. So it seems this custom node is not the problem. I am not sure why Comfy Manager is recommending I install Flow Control since it doesn't seem to actually be required. |
Looks like that nodepack includes the ComfyUI-GGUF nodeset in a subfolder for use in their own custom nodes, which makes sense. But for some reason the manager think it's required for any workflow that includes our nodes as it gets listed here as a duplicate despite never being exported here as far as I can tell. Pinging @ltdrdata - should probably have some logic for node class collisions with popular node sets as this could in theory be used as an exploit to force people to install unknown nodes. Also seems like an issue with the script that is used to parse node class mappings picking up any instance of |
The actual issue with the base nodes only listing gguf files seems to be caused by this bit of code in that linked node pack overriding the file list for the built in nodes. Something like this would work if the goal is to add orig = folder_paths.folder_names_and_paths.get("diffusion_models", folder_paths.folder_names_and_paths.get("unet", [[], set()]))
folder_paths.folder_names_and_paths["diffusion_models"] = (orig[0], {*orig[1], ".gguf"}) Though it might just be easier to create a new custom key and list both i.e how we do it here and here. @krich-cto |
This isn’t an issue that can be resolved by ComfyUI-Manager; it seems like it needs to be addressed on the core side. |
Unsure what you mean by core side but I think the main problem at hand should be resolvable by updating the db entry as the other node pack in question doesn't actually provide any of the conflicting nodes as far as I can tell, and they're just erroneously picked up despite not being imported anywhere (presumably because of a recursive scan function). |
Oh, I thought you were referring to the issue of another node overriding your nodes. I added the ComfyUI-GGUF nodes as a preemption nodes. |
Thanks that works for me |
Thank you, deleting helped me ComfyUI-Flow-Control |
and... how to uninstall [ComfyUI-Flow-Control] ???? thanks! |
You can uninstall any custom node by going into the comfy manager custom node list within comfyui. There will be a big list of custom nodes. Search your node in the text box to find it. Then click the uninstall button. |
now it works! Wow, it had been 3 days without a solution and reading in several forums I found this thread.. Thanks for the help!! |
Before installing the GGUF package, there was a UnetLoader node which can load my flux_dev.safetensors in my unet folder, everything was fine. After I installed the GGUF nodes, the UnetLoader node is gone and seems to be replaced by the Load Diffusion Model node, but the flux_dev.safetensors doesn't show in the node Load Diffusion Model, only .gguf models are listed, as shown in the pic.
I then loaded a workflow with the default flux_dev.safetensors file shown in the Load Diffusion Model node and tried to run it, and it triggered an error:
Prompt outputs failed validation
UNETLoader:
It seems that the safetensors are not included in the model list, but I placed the safetensors in the unet folder indeed.
The text was updated successfully, but these errors were encountered: