Assign taxTerm at top level on all forms

[eileenmcnaughton]

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.

Before

per #31532 the tax term (e.g VAT, GST) is only available if assigned

After

This, along with probably some other organizational settings, should really always be available to templates as it is frequently required

Technical Details

If this is merged there are other places it could be removed from

We could go with a crmSetting type smarty call - but it might be more disruptive

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[mattwire]

@eileenmcnaughton I understand the intent here but worry that putting it at the top-level is a bit of a sledgehammer. We don't seem to have any other similar assigns at this level and I would think that taxTerm sits at the same level as other vars such as language, currency, etc. which aren't currently assigned at this level. If we added taxTerm I imagine there's other vars that should similarly be added. There do seem to be some helper functions in CRM_Core_Form for adding other bits but maybe this assign would be better in a trait or helper function?

[kurund]

@eileenmcnaughton

Seems like good idea to assign it at top level. I am wondering if it should be part of config object rather than at form level?

We have things like currency as a part of config object which is already assigned to the template.

[eileenmcnaughton]

@kurund if the config object is already assigned wouldn't it already be assigned then? Are settings already magic-assigned that way (much as I hate those magic assigns)

[kurund]

@eileenmcnaughton

Sorry, missed your comment. When I checked last time it wasn't part of config object.

[mattwire]

My comments are non-blocking by the way, whatever @eileenmcnaughton and @kurund can agree on :-)