fixes #core-5641 add MembershipPayment and ParticipantPayment APIv4

[lcdservices]

Overview

Registers MembershipPayment and ParticipantPayment entities for APIv4.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[MegaphoneJon]

IIRC these weren't added intentionally, since the Line Item relationship should render them irrelevant. But that's not me expressing an opinion one way or the other, just repeating what I heard.

[demeritcowboy]

I think you're referring to the discussion here: https://chat.civicrm.org/civicrm/pl/4rypijzmofdbdekkh5kch4mkic

[colemanw]

I think these ought to be placed in ext/civi_member/Civi/Api4 and ext/civi_event/Civi/Api4, repectively.

[mattwire]

@lcdservices This keeps popping up but we've not added them because effectively both MembershipPayment and ParticipantPayment are deprecated in favour of LineItems.

[lcdservices]

But as far as I can see -- they have not yet been deprecated, and are actively in use. I feel like we should support them until they are actually deprecated. @colemanw your thoughts? -- and I moved them to the respective ext folders, PR is updated.

[mattwire]

Agree it's not entirely clear but anything that creates either of those entities should also be creating LineItems.

There is a note here: https://lab.civicrm.org/dev/core/-/issues/2486 - also see #29388

[seamuslee001]

See also #31538 which is something i came up following similar discussions happening in mattermost

[eileenmcnaughton]

I don't know that actively supporting them is the same as increasing support for them (ie adding apiv4) - we should do more to stop using them though - esp the membership payment which should be easier