RiverLea 1.2-5.81: regression fixes, adds crm-designer.css #31598
+289
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Before
Different numbering (1.80.14), issues with clipping drop-downs in Thames tables, dropdown-items bg colour,
and in Profile edit via event/contribution-pages, specifically:
Minetta:
Thames:
After
1.2-5.81. Issues resolved.
Minetta:
Hackney:
Walbrook:
Thames:
Technical Details
The big change with this PR is the addition of
crm.designer.css
, to over-ride core, and tackle a related bug: https://lab.civicrm.org/extensions/riverlea/-/issues/92. This CSS file only targets the backbone.js drag-and-drop profile edit UX, and much of the code from that remains. However, my port has changed a few things to CSS variables, and fixed legibility issues.There is one notable difference with RiverLea's version of the profile edit modal over Greenwich's - the left and right columns scroll together, not independently, as pointed out here.