Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RiverLea 1.2-5.81: regression fixes, adds crm-designer.css #31598

Open
wants to merge 3 commits into
base: 5.81
Choose a base branch
from

Conversation

vingle
Copy link
Contributor

@vingle vingle commented Dec 12, 2024

Overview

Before

Different numbering (1.80.14), issues with clipping drop-downs in Thames tables, dropdown-items bg colour,
and in Profile edit via event/contribution-pages, specifically:

  • scroll doesn't work
  • bottom overlaps dialog boundary
  • drag handles overlap text
  • delete/edit buttons have border.
  • colours don't match Stream.

Minetta:
image

Thames:
image

After

1.2-5.81. Issues resolved.

Minetta:
image

Hackney:
image

Walbrook:
image

Thames:
image

Technical Details

The big change with this PR is the addition of crm.designer.css, to over-ride core, and tackle a related bug: https://lab.civicrm.org/extensions/riverlea/-/issues/92. This CSS file only targets the backbone.js drag-and-drop profile edit UX, and much of the code from that remains. However, my port has changed a few things to CSS variables, and fixed legibility issues.

There is one notable difference with RiverLea's version of the profile edit modal over Greenwich's - the left and right columns scroll together, not independently, as pointed out here.

Copy link

civibot bot commented Dec 12, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the 5.81 label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant