fix: display correct cluster type during creation with --wait flag #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ealier it had a hard-coded cluster type value, now it take the value from --cluster-type flag, or defaults to k3s if nothing specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create a cluster with
--waitflag, the spinner message says, creating ak3scluster, even if the cluster type istalos, now it takes the value from from--cluster-typeflag, or defaults tok3sif nothing specified.Issue:
If you see, we are creating a
taloscluster, but the spinner message saysk3s:Result:
Correctly picking up the cluster type now:
Rightly defaulting to
k3s: