add jdk http client #250
Open
add jdk http client #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be a really nice addition. Especially if it's easy to configure an NioEventLoopGroup as the executor |
I'll keep that in mind. |
|
Part of #251 |
zettelmj
force-pushed
the
add_jdk_http_client
branch
from
9e12ce9 to
746fabf
Compare
zettelmj
force-pushed
the
add_jdk_http_client
branch
from
030aa3a to
e4d6b15
Compare
|
@cjbooms this is ready for merge with the caveat that I would consider it experimental: things will be missing. I've tried to reuse the okio test cases. |
|
Sorry I missed this. Will try and get this merged this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add jdk http client