Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client streaming flag protection #314

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Add client streaming flag protection #314

merged 1 commit into from
Sep 16, 2024

Conversation

averabaq
Copy link
Collaborator

It only allows to override byte-array to input-stream data type generation on server-side code. This override is ignored on the client side until full streaming is supported.

WARNING: Client code generation does not support streaming, yet. The override flag 
'BYTEARRAY_AS_INPUTSTREAM' is ignored. If generating server side code, please consider 
splitting the client & server in different fabrikt executions. Defaulting to `ByteArray`...

@averabaq averabaq requested a review from cjbooms September 13, 2024 10:33
cjbooms
cjbooms approved these changes Sep 16, 2024
View reviewed changes
Copy link
Owner

@cjbooms cjbooms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjbooms cjbooms merged commit 6528da2 into master Sep 16, 2024
1 check passed
@cjbooms cjbooms deleted the task/client_streaming_flag_protection branch September 16, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjbooms cjbooms cjbooms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@averabaq @cjbooms