From 6d2382eb29b57199a32340c1124beb7ab4318ae2 Mon Sep 17 00:00:00 2001 From: Connor Pearson Date: Wed, 15 Nov 2017 18:40:50 -0500 Subject: [PATCH] Update removing keyboard observer comment (#64) --- src/ios/CDVKeyboard.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ios/CDVKeyboard.m b/src/ios/CDVKeyboard.m index 3305f9d..3c04548 100644 --- a/src/ios/CDVKeyboard.m +++ b/src/ios/CDVKeyboard.m @@ -144,8 +144,8 @@ - (void)setHideFormAccessoryBar:(BOOL)hideFormAccessoryBar - (void)setShrinkView:(BOOL)shrinkView { - // When the keyboard shows, WKWebView shrinks window.innerHeight. This isn't helpful when we are already shrinking the frame - // They removed this behavior is iOS 10, but for 8 and 9 we need to prevent the webview from listening on keyboard events + // Remove WKWebView's keyboard observers when using shrinkView + // They've caused several issues with the plugin (#32, #55, #64) // Even if you later set shrinkView to false, the observers will not be added back NSNotificationCenter* nc = [NSNotificationCenter defaultCenter]; if ([self.webView isKindOfClass:NSClassFromString(@"WKWebView")]) {