Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a default error.html file to the nginx configuration #177

Closed
kowh-ai opened this issue Oct 9, 2024 · 2 comments · Fixed by #179
Closed

Add a default error.html file to the nginx configuration #177

kowh-ai opened this issue Oct 9, 2024 · 2 comments · Fixed by #179
Assignees
@kowh-ai
Labels
Good for Contribution

Comments

@kowh-ai
Copy link
Contributor

kowh-ai commented Oct 9, 2024

Related: PR

nginx will serve a 404 when an error occurs as it cannot find an error.html file:

We should add an error.html file to the configuration
@kowh-ai kowh-ai self-assigned this Oct 9, 2024
@Nisha1293
Copy link

Hi @kowh-ai
I want to resolve this issue. Do we need to update the custom error page, or is the following error page content sufficient?

error.html

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Error</title>
</head>
<body>
    <h1>Oops! Something went wrong.</h1>
    <p>We're sorry, but the page you requested could not be found.</p>
</body>
</html>

If this is okay, I will raise the PR. Please let me know your suggestion.

@kowh-ai
Copy link
Contributor Author

kowh-ai commented Oct 14, 2024

@Nisha1293 - Yes I think this looks OK...please create a PR and I will test it - thanks

@Nisha1293 Nisha1293 mentioned this issue Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kowh-ai kowh-ai

Labels
Good for Contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add new error.html file Nisha1293/ckan-docker
2 participants
@kowh-ai @Nisha1293