Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not download data when running #2

Open
frafra opened this issue Feb 18, 2022 · 0 comments · May be fixed by #3
Open

Do not download data when running #2

frafra opened this issue Feb 18, 2022 · 0 comments · May be fixed by #3

Comments

@frafra
Copy link

frafra commented Feb 18, 2022

ckan-postgres-dev/docker-entrypoint-initdb.d/02_datastore_permissions.sh

Lines 6 to 13 in f8c1eca

if [ $CKANVERSION == 'master' ]
then
wget https://raw.githubusercontent.com/ckan/ckan/dev-v$CKAN_VERSION/ckanext/datastore/set_permissions.sql \
-O /tmp/set_permissions.sql
else
wget https://raw.githubusercontent.com/ckan/ckan/$CKAN_VERSION/ckanext/datastore/set_permissions.sql \
-O /tmp/set_permissions.sql
fi

Adding files should happen when building, not when running. How about using ADD in Dockerfile and avoid such if conditions to make things easier?

This would also make it possible to use non-alpine images, as regular Postgres images do not have wget, while the Alpine image has wget as an alias for busybox.
@frafra frafra linked a pull request Feb 18, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run image without internet connection frafra/ckan-postgres-dev
1 participant
@frafra