Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: does it track DataStore API usage? #22

Open
MrkGrgsn opened this issue Oct 20, 2016 · 5 comments
Open

Question: does it track DataStore API usage? #22

MrkGrgsn opened this issue Oct 20, 2016 · 5 comments

Comments

@MrkGrgsn
Copy link

Does this track DataStore API usage? My read of the code is that it doesn't; I can't see it overriding the datastore actions mapping anywhere, but I just wanted to confirm.

@gleb-rudenko
Copy link

@MrkGrgsn , no, it doesn't

@MrkGrgsn
Copy link
Author

Thanks @gleb-rudenko. It would be neat if this extensions had a plugin interface so that other CKAN extensions that add actions can register those actions for GA tracking.

@gleb-rudenko
Copy link

I'll work on it

gleb-rudenko pushed a commit to gleb-rudenko/ckanext-googleanalytics that referenced this issue Mar 27, 2017
smotornyuk added a commit that referenced this issue May 4, 2017
#22 / no interface needed, function _post_analytics modified
@smotornyuk
Copy link
Member

Does anyone had chance to use it? It looks quite ok for me. Maybe, @gleb-rudenko , you should add little bit more details about you new function. And, if it supposed to be used by others, remove underscore from it's name
PS i just thought about it, after merging your previous PR, so could you please create new one?

gleb-rudenko pushed a commit to gleb-rudenko/ckanext-googleanalytics that referenced this issue May 5, 2017
@anuveyatsu
Copy link

anuveyatsu commented Jul 24, 2019

@smotornyuk I've used it with datastore_search action and it did send analytics data, however, it couldn't identify event label (el) which should be the value of resource_id I suppose. I think it is related to #39

I would make a PR for this so that it tries to use name_or_id or resource_id if id is unavailable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants