Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken compatibility with py2.7 #256

Open
ccancellieri opened this issue Oct 20, 2021 · 0 comments · May be fixed by #257
Open

Broken compatibility with py2.7 #256

ccancellieri opened this issue Oct 20, 2021 · 0 comments · May be fixed by #257

Comments

@ccancellieri
Copy link
Contributor

ccancellieri commented Oct 20, 2021 •
edited
Loading

Hi,
I'm trying to use ckanext-spatial (with harvester for csw iso19139),

I'm over a fresh (docker) installation of ckan-2.8 and python 2.7 and I've just realized that 5 months ago a massive change (#249) has been merged (impressive job!).

Even if that is really appreciated for the py3 migration, it looks like it is not working anymore on python2.7.

I've fixed it (the portion I'm testing) and I'm wondering if a pull req will be acceptable on master to keep it working with python2 AND python3, the patch is not invasive but adds some static logic to check the encoding.

What do you think?

Feedback is welcome
ccancellieri added a commit to ccancellieri/ckanext-spatial that referenced this issue Oct 20, 2021
@ccancellieri
fix encoding problem on py2.7 ckan#256
1eb38dd
@ccancellieri ccancellieri linked a pull request Oct 20, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix broken support to py2.7 #256 ccancellieri/ckanext-spatial
1 participant
@ccancellieri