Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PyPDF4 changes back to PyPDF2 #104

Open
MartinThoma opened this issue Apr 9, 2022 · 0 comments
Open

Merge PyPDF4 changes back to PyPDF2 #104

MartinThoma opened this issue Apr 9, 2022 · 0 comments

Comments

@MartinThoma
Copy link

As PyPDF2 is maintained again (I'm the new maintainer) and it seems like PyPDF4 still is way smaller, I'd be happy if the two communities merged together again. I'm still struggling with lots of PRs on PyPDF2 side, but please feel free to add small ones there again :-)

A good PR has the following properties:

  1. It does one thing, and does it well: Try to keep the size of the PR small
  2. It explains a little bit what it's about. Is it a bugfix? Is it a feature? Just a stylistic change? Why is it a good idea to add it?
  3. It contains a unit test. If it's a bugfix, it contains a test that now succeeds but was failing before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant