Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local regression tests and GitHub CI workflow #180

Open
carlosmunozmoncayo opened this issue Aug 27, 2024 · 1 comment
Open

Local regression tests and GitHub CI workflow #180

carlosmunozmoncayo opened this issue Aug 27, 2024 · 1 comment

Comments

@carlosmunozmoncayo
Copy link
Contributor

It could be useful to have some testing workflow for the Riemann solvers. I was thinking about writing some Pytest-based regression tests for the Python and f2py-compiled Fortran solvers. The idea would be to compare, for a set of problems, the output of each solver (waves, speeds, normal and transverse fluctuations) with some reference values stored in dictionaries, instead of focusing on the Riemann solution itself. Would something like this make sense?

@mandli
Copy link
Member

mandli commented Aug 27, 2024

We did have something that would effectively call a Riemann solver in a mode that would be an actual Riemann problem. Something like that would be useful although I am not sure how hard it would be to hook up generally to the Fortran Riemann solvers that use things like modules. A Fortran test harness maybe appropriate even in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants