Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement request: Explicit __all__ defining exported names #96

Open
charles-dyfis-net opened this issue Dec 19, 2023 · 0 comments · May be fixed by #101
Open

Enhancement request: Explicit __all__ defining exported names #96

charles-dyfis-net opened this issue Dec 19, 2023 · 0 comments · May be fixed by #101

Comments

@charles-dyfis-net
Copy link

mypy --strict flags code that tries to use aioprometheus.Counter:

error: Module "aioprometheus" does not explicitly export attribute "Counter"  [attr-defined]

Consider setting __all__ with a list of imported contents that are explicitly re-exported as part of a stable interface.
@charles-dyfis-net charles-dyfis-net changed the title Enhancement requests: Explicit __all__ defining exported names Enhancement request: Explicit __all__ defining exported names Dec 19, 2023
@owenwastaken owenwastaken linked a pull request Aug 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add __all__ variable to __init__.py owenwastaken/aioprometheus
1 participant
@charles-dyfis-net