Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom carousel—with only one or two events, disable swipe #29

Closed
jamiefolsom opened this issue Sep 19, 2014 · 5 comments
Closed

Bottom carousel—with only one or two events, disable swipe #29

jamiefolsom opened this issue Sep 19, 2014 · 5 comments
Assignees
Milestone

Comments

@jamiefolsom
Copy link
Collaborator

No description provided.

@heymarkreeves
Copy link
Member

See also #35

bxSlider (detailed in #35) does not support an option to disable swipe based on only 1 or 2 slides, which does look a bit odd.

One possibility here is to set infiniteLoop: false in bxSlider's options, which may prove necessary if lazy loading were to be implemented in the future. This would effectively keep the same slide from being swiped repeatedly, but would also affect a scenario with 20 slides: You'd need to swipe back through all 20 to get to the first. We'd also need to implement a disabled state for prev/next buttons at start/end.

(Also a consideration: All sliders are handled by the same scripting, including Related Events, etc.)

Conclusion: This is something we can do, but need to acknowledge that it would remove infinite loop in all cases.

@desigonz
Copy link

Liam and I both lean toward disabling infinite loop for the bottom nav. Does this remove infinite loop in the case of the recommended events on the home/discover page?

@heymarkreeves
Copy link
Member

Thanks, @desigonz! @SherriAlexander: If we set infiteLoop: false on the bottom carousels, it will affect all footer carousels, but will it affect the large Discover carousel?

@SherriAlexander
Copy link
Collaborator

Hey there! The settings for the Discover slider at the top are kept separate from the settings for the footer carousel at the bottom, so we can alter one without affecting the other.

SherriAlexander added a commit that referenced this issue Nov 11, 2014
… there aren't more items to swipe to (Github issue #29)
@SherriAlexander
Copy link
Collaborator

Hey there! This is all set now -- we've disabled the infinite loop behavior, so the footer carousel will no longer allow you to swipe if there are no real items to swipe to. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants