Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

large screens #48

Open
desigonz opened this issue Oct 9, 2014 · 5 comments
Open

large screens #48

desigonz opened this issue Oct 9, 2014 · 5 comments
Assignees

Comments

@desigonz
Copy link

desigonz commented Oct 9, 2014

Map view and event images on large screens: map/image should expand vertically (see screenshot)
img_0087

img_0088

@SherriAlexander
Copy link
Collaborator

I've increased the maximum height allowed for both the map and the detail images to 340 pixels, which matches up with the Discover slider on the homepage and looks good at tablet and desktop widths. This should be all set now! :)

@desigonz
Copy link
Author

Hi Sherri,

Thanks for looking into this! These images are now too tall on my iPhone 4. I've included screens below that illustrate this (one view is from the browser, the other is from the homescreen icon). Is it possible to maintain the previous height for smaller screens and a different height for larger screens?

photo 1
photo 2

SherriAlexander added a commit that referenced this issue Nov 19, 2014
…ght until the tablet breakpoint (Github issue #48)
@SherriAlexander
Copy link
Collaborator

Hey there -- Absolutely; I've just changed it up so that the original maximum height of 200px will carry through until the tablet breakpoint, and from that point onward it will go up to the 340px maximum. This should hopefully do the trick. :) Let me know what you think when you can. Thanks!

@heymarkreeves
Copy link
Member

@desigonz Can you close once you've confirmed this is all set? Thanks!

@desigonz
Copy link
Author

Thanks, that looks great!

We were wondering if you could do a similar thing for the bottom carousel on large screens. When you use Artbot on an iPad, the thumbnails stay at the same height as on a small screen, so about six or seven thumbnails appear at a time—and we often don't have that many related events. If it's possible, it would be great if you could set a different maximum for the bottom carousel on large screens to only show three or four events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants