Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to pass additional querystring vars #7

Closed
nathanpitman opened this issue Jun 23, 2014 · 2 comments · Fixed by #9
Closed

Ability to pass additional querystring vars #7

nathanpitman opened this issue Jun 23, 2014 · 2 comments · Fixed by #9

Comments

@nathanpitman
Copy link

It would be neat to be able to pass additional embed querystring vars, i.e. we often want to hide the 'info bar' for YouTube vids... showinfo=0

:)

@bryanburgers
Copy link
Contributor

@nathanpitman Agreed. I also want this. (Sorry for the slow response.)

I'm thinking through the API here.

{videolink-field:embed
    width="..."
    height="..."
    youtube:controls="2"
    youtube:showinfo="0"
    vimeo:other="x"}

If this is a YouTube embed, we'd get //www.youtube.com/embed/1234?rel=0&controls=2&showinfo=0. If it's a Vimeo embed, we'd get //player.vimeo.com/video/1234?other=x.

I like this API. It seems intuitive enough.

I think we also need to think about how we're going to pass parameters to the <iframe> tag itself, instead of the embed URL. (See #6.) This syntax would let us do iframe:wmode="Opaque". Would a user would ever want to pass an iframe parameter to just a YouTube iframe, or to just a Vimeo iframe? Then what's the parameter? iframe:youtube:wmode="Opaque"?

We only support Vimeo and YouTube right now, and both are embedding using an <iframe>. So it's probably too early to think about what we would do if we needed to support a service that uses <embed>.

@nathanpitman @Mark-cr @bfopma @cmtracy Thoughts? Does this syntax look alright? Does the iframe:parameter="..." syntax look acceptable?

@nathanpitman
Copy link
Author

Syntax looks good, RE iFrames/Embeds... does anyone provide embed only support these days? The general trend seems to be towards iFrame over embed so perhaps there's no need to worry too much about embeds? iFrames generally provide better support across devices so I can't see this trend changing anytime soon. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants