Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: XUL referencing - body, page, window #181

Open
h6w opened this issue Dec 18, 2012 · 5 comments
Open

Discussion: XUL referencing - body, page, window #181

h6w opened this issue Dec 18, 2012 · 5 comments

Comments

@h6w
Copy link
Contributor

h6w commented Dec 18, 2012

As I understand it, in a XUL app in Firefox, each page or window would be a separate file. Creating a window dynamically would result in the window or page being referenced by id. Every file in a folder is automatically imported.

In Ample, however, we have to have a "root" by which we reference the containing pages and load them using scripts. Ample's root is "body" in one sense, but "body" isn't technically in the XUL namespace and layout at this level is unclear and can cause miscalculations and things being incorrectly hidden, shown, or placed. You can't, for example, add windows to "body" dynamically. Whereas adding a window to a page is technically incorrect according to XUL's reference implementation and tutorials. Ample's behaviour in this regard is correct, however it means this needs to be solved in some way that makes sense, particularly differentiating XUL that was preloaded as opposed to ones that are dynamically created.

@AmicaNoctis
Copy link
Contributor

Since XUL in Ample (in most of the cases) features having a full-screen main window (xul:page) plus some additional windows, that may be regarded as popup windows, I'd suggest to add them to xul:popupset.

@h6w
Copy link
Contributor Author

h6w commented Jan 2, 2013

Thanks for the suggestion.

I tried it, but it doesn't seem to work:

http://pastebin.com/Rx83aRVP

image

According to https://developer.mozilla.org/en-US/docs/XUL/popupset , popupset is a "container for menupopup, panel, and tooltip elements."

@AmicaNoctis
Copy link
Contributor

H6w,

sorry for being unclear in the first place. My suggestion didn't mean "try to do it that way", but rather "I would vote for it to be implemented that way". I am aware that popupset is actually a slightly different thing according to the specs, but xul:window in Ample also is. Technically it is just a popup panel resembling the L'n'F of a window.

Amica

@h6w
Copy link
Contributor Author

h6w commented Jan 2, 2013

oic! Well, I'd like to keep to the tutorials as closely as possible. Either some sort of autoloading or placement at the same level as the page element would be my preference. I'm trying to make it as close to the original as possible for ease of porting existing XUL apps.

@AmicaNoctis
Copy link
Contributor

This is also a good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants