Dh sequencer #2
Dh sequencer #2
Conversation
| @@ -99,7 +99,7 @@ newSourceDebDescription = | |||
| , _homepage = Nothing | |||
| , _vcsFields = Set.empty | |||
| , _xFields = Set.empty | |||
| , _xDescription = Nothing -- Quick hack, I should maybe put this into _xFields | |||
| , _description = Nothing -- Quick hack, I should maybe put this into _xFields | |||
There was a problem hiding this comment.
David's comment could probably be deleted too
There was a problem hiding this comment.
Yes, I agree. I was not sure, however, what the relationship is with _xFields here (and with similarly named symbols elsewhere). Are more refactorings needed?
There was a problem hiding this comment.
No, I think the only problem left to resolve is that you've introduced a naming clash in the re-exports of Debian.Debianize
There was a problem hiding this comment.
Would it be acceptable to qualify the imports with S and B, as they are in Tests.hs?
| @@ -42,7 +42,7 @@ main = performDebianization customize | |||
|
|
|||
| -- Add dependencies to the binary debs. | |||
| (debInfo . binaryDebDescription (BinPkgName "cabal-debian") . relations . depends) %= | |||
| (++ (rels "apt-file, debian-policy, debhelper, haskell-devscripts (>= 0.8.19)")) | |||
| (++ (rels "apt-file, debian-policy, dh-sequence-haskell, haskell-devscripts (>= 0.16.8)")) | |||
There was a problem hiding this comment.
What are the impediments to not doing as the commit message says?
There was a problem hiding this comment.
Probably none—except I am not sure how to pull the desired compat value from Policy.hs.
There was a problem hiding this comment.
Hi, does this file (in ./debian) describe cabal-debian or the target being debianized?
…/control. (Closes: #1009162)
The Haskell build system now prefers that field:
https://salsa.debian.org/haskell-team/haskell-devscripts/-/commit/71fa2f669350ed4e9e0013c8d749b45166c78196
It would be better to use the modern combined prerequisite
"debian-compat (= 13)"
and drop the separate d/compat file.
For common review.
Not tested and most likely not working.