Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat watch #236

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Feat watch #236

wants to merge 2 commits into from

Conversation

Mobilpadde
Copy link

@Mobilpadde Mobilpadde commented Nov 22, 2021

Description

I've requested this directly in the Telegram group. Though I didn't know how long to wait, so I decided to give it a go myself.

I decided to use chokidar as fs.watch can give problems on some platforms.

Changes proposed in this pull request

  • New dev command added - this will watch for changes clio-files.
  • Changes made to clio.toml as seen below
[npm.devDependencies]
rollup = "^2.56.2"
clio-rollup = "latest"
"@babel/preset-env" = "^7.15.0"
serve = "latest"

[npm.scripts]
host = "node .clio/host.js"
build = "rollup -c"
dev = "rollup -c -w"
start = "npm run build && serve public"

Instead of using sirv it's using serve, as sirv didn't reflect new changes to the built code.

ToDo

  • Proposed feature/fix is sufficiently tested - only tested manually. Could use some help with it.
  • Proposed feature/fix is sufficiently documented

Note, this is the first large PR in forever. Hopefully it's done correctly 👍

@@ -10,43 +10,20 @@
"license": "Apache-2.0",
"dependencies": {
"@iarna/toml": "^2.2.5",
"@rollup/plugin-alias": "^3.1.2",
Copy link
Author

@Mobilpadde Mobilpadde Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I've done something wrong with this file? Might be lerna releated? - never used lerna before 🗡️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant