Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minifying es6 #53

Open
rangeoshun opened this issue Oct 18, 2018 · 3 comments
Open

Minifying es6 #53

rangeoshun opened this issue Oct 18, 2018 · 3 comments

Comments

@rangeoshun
Copy link

rangeoshun commented Oct 18, 2018

I'd like to add the package diffDOM to cljsjs/packages. It does not provide minified version, so would like to minify it with the built-in task. It fails due to the fact that the minify only provides an option that specifies language-in. Setting this to ES6 results in the following error message:

ES6 is only supported for transpilation to a lower ECMAScript version. Set --language_out to ES3, ES5, or ES5_STRICT.

Since yesterday, it is possible to specify both language-in and language-out for asset-minifier through this PR. With the default in being :ecmascript6 and :ecmascript5 as output.

Deraen added a commit that referenced this issue Oct 25, 2018
…w-es6-minification

Update asset-minifier to allow es6 minification #53
@rangeoshun
Copy link
Author

rangeoshun commented Oct 26, 2018

Thanks for the merge @Deraen ! What's next? Should I just use v0.10.3 in my package, or you'd like to update them all?

@Deraen
Copy link
Member

Deraen commented Oct 26, 2018

I updated all deps now, but in such cases it is also fine to start using new version in single package as needed.

@rangeoshun
Copy link
Author

rangeoshun commented Oct 26, 2018

Ok, will remember that. Did you not update lang option on purpose? I mean it should be still ok, just the output language won't be as expected in some cases. That is if lang is set to es3, it'll be es5 instead. Thanks, I just saw, it's not an issue as no package does this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants