Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling the reference max size in database in backend requests #14

Open
Somebodyisnobody opened this issue Sep 21, 2022 · 0 comments
Open

Comments

@Somebodyisnobody
Copy link
Contributor

In legacyclonk/LegacyClonk#67 we discussed about removing the address limit. @maxmitti noticed, that the maximum size of a record is 64Kb as the database column reference is defined as text in table_structure.sql

league/table_structure.sql

Lines 216 to 220 in ae49dd4

CREATE TABLE IF NOT EXISTS `lg_game_reference` (
`game_id` int(10) unsigned NOT NULL AUTO_INCREMENT,
`reference` text NOT NULL,
PRIMARY KEY (`game_id`)
) ENGINE=MyISAM DEFAULT CHARSET=latin1;

Independently of the address limit, the title, the required definitions, the number of players, etc. can also reach the 64K b deliberately maliciously or with no awareness. For example, the addresses are not parsed for validity. A 50,000 digit IPv6 address would be possible.

From operations management perspective (@lluchs), is the behavior of the backend a problem that should or should not be resolved? If so, what steps should be taken to address the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant