Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Add tests #146

Open
neob91-close opened this issue Nov 14, 2022 · 4 comments
Open

Add tests #146

neob91-close opened this issue Nov 14, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@neob91-close
Copy link
Contributor

We have no tests whatsoever for lintlizard, while it should be fairly easy to mock out subprocess and make assertions on what commands are executed (and potentially what output is generated by lintlizard).
@neob91-close neob91-close added the enhancement New feature or request label Nov 14, 2022
@vtclose
Copy link
Contributor

vtclose commented Nov 14, 2022

Half of the "test suite" of lintlizard is running it on itself in CI. I agree having some actual tests would be nice though. As well as testing failures.

@neob91-close
Copy link
Contributor Author

Well, --fix or --changed aren't running in CI (to my knowledge), so it's possible to break them without noticing

@neob91-close
Copy link
Contributor Author

It's only checking for non-zero exit codes, right?
#147

@vtclose
Copy link
Contributor

vtclose commented Nov 15, 2022

Yep that's true, it's only regular runs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vtclose @neob91-close