Blocked pop-up

[kwheelan]

Related to #134

When the app tries to open a new tab after conversion, both Chrome and Safari block the new tab, sometimes with a warning. This may have been the issue @lucakato you were trying to fix with #118 / #117? That new tab isn't blocked, but it opens too early.

[lucakato]

hmm interesting I never get a popup blocking the new tab. I'll look into it ty. either way functionality needs to be improved #134

[kwheelan]

I hadn't noticed the issue before either, so maybe it's because of a recent Chrome update?

[lucakato]

@kwheelan could you check dev to see you're getting popup blocked? I don't get it (tested on Chrome and Safari). Made a push that also addresses #134

[kwheelan]

@lucakato No blocked popup but that's because it just opened in the same tab instead of opening a new tab. Was that the intention?

[lucakato]

@kwheelan Not really, because my attempts kept getting the popup blocked. I can't test this on the CLOSUP website (it may fail to load when embedded in another site) but I just talked to Margaret and she said we could just decide not to embed it in website. So we could leave it as is for now?

The other option is:
I think the way it worked before was the route was set to /upload/ even after conversion. This seemed to work even in the embedded website. Now I have it go to /upload/complete because I think that makes more sense. But we could revert it to that method.

[kwheelan]

@lucakato You can definitely try reverting, but I wonder if the issue is a new Chrome version that auto-blocks popups rather than the change to /upload/complete? Anyway maybe it's worth a try to revert and we can test embedded/not embedded and both Safari and Chrome. If that fails, just keeping the site unembedded and never opening a new tab seems like a fine solution to me.