Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package versions #163

Closed
kwheelan opened this issue Jan 12, 2025 · 2 comments
Closed

Package versions #163

kwheelan opened this issue Jan 12, 2025 · 2 comments

Comments

@kwheelan
Copy link
Collaborator

kwheelan commented Jan 12, 2025

Make the releases static to avoid code breaks

Fixed the issue for ixbrl-viewer and arelle in #167 but we still need to specify versions for the rest of the packages in requirements.txt

@kwheelan kwheelan added the bug label Jan 12, 2025
This was referenced Jan 12, 2025
Merged
@kwheelan kwheelan changed the title Submodule versions Package versions Jan 12, 2025
@lucakato
Copy link
Collaborator

@kwheelan does this mean any other packages we use, we just specify them in requirements.txt?

@kwheelan
Copy link
Collaborator Author

@lucakato Right -- just specify the current version like we have here:

mammoth == 1.7.0

Otherwise, if there's just the package name and no version, any new deployment will use the most recent version which could break the code (like what happened with ixbrl-viewer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants