Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter AWS_S3 service from host template validation check #161

Conversation

wmudge
Copy link
Member

@wmudge wmudge commented Nov 10, 2023

No description provided.

@wmudge wmudge added the bug Something isn't working label Nov 10, 2023
@wmudge wmudge added this to the Release 4.2.0 milestone Nov 10, 2023
@wmudge wmudge requested a review from a team November 10, 2023 04:16
@wmudge wmudge linked an issue Nov 10, 2023 that may be closed by this pull request
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested this change by adding the AWS_S3 service to the definition in cloudera-labs/cloudera-deploy#119.

Confirmed that issue described in #162 is resolved with this change.
Note that I didn't test the external account configuration as part of this test.

@wmudge wmudge marked this pull request as ready for review November 14, 2023 14:18
@wmudge wmudge requested a review from jimright November 14, 2023 14:19
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested with cloudera_manager_external_account configuration and adding the AWS_S3 service. Cluster was deployed successfully with the S3 connector service.

@wmudge wmudge merged commit 03de94d into cloudera-labs:devel Nov 14, 2023
4 checks passed
@wmudge wmudge deleted the fix/aws_s3_service_exclude_host_template_check branch November 14, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Update AWS_S3 service validation
2 participants