Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling smelly selector checks #1162

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Allow disabling smelly selector checks #1162

merged 1 commit into from
Oct 23, 2024

Conversation

prymitive
Copy link
Collaborator

Fixes #1096.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.66.1-44-gebb8f7a
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   40.34m ± 2%   40.16m ± 2%       ~ (p=0.436 n=10)
CheckRules-4     8.539 ± 2%    8.511 ± 2%       ~ (p=0.971 n=10)
geomean         586.9m        584.6m       -0.40%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.41Mi ± 0%   27.41Mi ± 0%       ~ (p=0.393 n=10)
CheckRules-4    974.7Mi ± 0%   975.9Mi ± 0%       ~ (p=0.481 n=10)
geomean         163.4Mi        163.5Mi       +0.06%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.9k ± 0%   131.9k ± 0%       ~ (p=1.000 n=10)
CheckRules-4    14.17M ± 0%   14.18M ± 0%       ~ (p=0.190 n=10)
geomean         1.367M        1.367M       +0.02%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.79%. Comparing base (14f0935) to head (ebb8f7a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1162   +/-   ##
=======================================
  Coverage   94.78%   94.79%           
=======================================
  Files         104      104           
  Lines       12258    12274   +16     
=======================================
+ Hits        11619    11635   +16     
  Misses        487      487           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 012cb00 into main Oct 23, 2024
20 checks passed
@prymitive prymitive deleted the smelly branch October 23, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

promql/regexp lint warning about 'smelly selector' can't be specifically disabled
2 participants