You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've got a Modal component which renders the modal box + its children if it's own open prop is set to true. This is run through VelocityTransitionGroup, which means if the open prop changes, it'll add remove/children respectively.
The purpose of using react-gateway was to avoid an issue with nested forms, where the modal rendered its own form, after being triggered by an existing form's element event.
Question
Why is it necessary to completely delete all the children?
If my Modal is set to open={true}, it'll continuously try to re-render the children, because sending a <Modal open={true} /> into Gateway instructs the modal to add its own children, thus triggering componentWillReceiveProps onGateway, and effectively deleting it and adding it continuously.
The text was updated successfully, but these errors were encountered:
Alright, I might have caused a recursive loop with the content I was trying to load into this Modal.
I'd suppose if we shift the focus toward what the core idea is behind the rendering/replacing of the children to the Gateway, that might help me understand what went wrong there. Sorry for any confusion, I can appreciate the ticket was a little loose.
Description
I've got a
Modal
component which renders the modal box + its children if it's ownopen
prop is set totrue
. This is run throughVelocityTransitionGroup
, which means if theopen
prop changes, it'll add remove/children respectively.This causes an infinite render bug due, which I believe is due to lines 34 - 36 in GatewayRegistry.js.
Background information
The purpose of using
react-gateway
was to avoid an issue with nested forms, where the modal rendered its own form, after being triggered by an existingform
's element event.Question
Why is it necessary to completely delete all the children?
If my
Modal
is set toopen={true}
, it'll continuously try to re-render the children, because sending a<Modal open={true} />
intoGateway
instructs the modal to add its own children, thus triggeringcomponentWillReceiveProps
onGateway
, and effectively deleting it and adding it continuously.The text was updated successfully, but these errors were encountered: