Spring Auto Reconfiguration is not operational when deploying EAR #23

violetagg · 2017-08-18T08:59:59Z

When Spring Auto Reconfiguration is enabled and there is spring-core*.jar artifacts [1]
in the application binaries, a modification of web.xml provided by web module will be made
and Spring Auto Reconfiguration jar file will be added to the additional libraries [2].

When the deployment artifact is WAR file the collection of the additional libraries will be added
to WEB-INF/lib [3]. Thus Spring Auto Reconfiguration will be able to load classes provided by spring-core*.jar.

In case of EAR the additional libraries will be added to <TomEE-Home>/lib [3]. Thus
Spring Auto Reconfiguration will not be able to load the classes provided by spring-core*.jar
because they are provided by the application binaries and not by TomEE installation.

The exception below will appear:

   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT Caused by: java.lang.NoClassDefFoundError: org/springframework/context/ApplicationContextInitializer
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.lang.ClassLoader.defineClass1(Native Method)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.security.AccessController.doPrivileged(Native Method)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.openejb.core.TempClassLoader.loadClass(TempClassLoader.java:225)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.openejb.core.TempClassLoader.loadClass(TempClassLoader.java:83)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.cloudfoundry.reconfiguration.spring.AutoReconfigurationServletContainerInitializer.<clinit>(AutoReconfigurationServletContainerInitializer.java:33)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.lang.Class.forName0(Native Method)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.lang.Class.forName(Class.java:348)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.catalina.startup.WebappServiceLoader.loadServices(WebappServiceLoader.java:188)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.catalina.startup.WebappServiceLoader.load(WebappServiceLoader.java:159)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.catalina.startup.ContextConfig.processServletContainerInitializers(ContextConfig.java:1622)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.catalina.startup.OpenEJBContextConfig.processServletContainerInitializers(OpenEJBContextConfig.java:479)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1135)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.catalina.startup.OpenEJBContextConfig.webConfig(OpenEJBContextConfig.java:402)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:775)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.catalina.startup.OpenEJBContextConfig.configureStart(OpenEJBContextConfig.java:123)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:299)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:94)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5087)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	... 23 more
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT Caused by: java.lang.ClassNotFoundException: org.springframework.context.ApplicationContextInitializer
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
   2017-08-10T14:37:48.66-0400 [APP/PROC/WEB/0] OUT 	... 52 more

[1] https://github.com/cloudfoundry-community/tomee-buildpack/blob/master/lib/java_buildpack/framework/spring_auto_reconfiguration.rb#L53
[2] https://github.com/cloudfoundry-community/tomee-buildpack/blob/master/lib/java_buildpack/framework/spring_auto_reconfiguration.rb#L39
[3] https://github.com/cloudfoundry-community/tomee-buildpack/blob/master/lib/java_buildpack/container/tomee/tomee_instance.rb#L62

The text was updated successfully, but these errors were encountered:

violetagg · 2017-08-18T09:01:44Z

cc @kelapure

bijukunjummen · 2017-08-29T04:06:33Z

@kelapure and I are starting to look at this @violetagg - one question though, how did you get this condition to trigger to simulate the scenario for the ear file:

@configuration['enabled'] && (@droplet.root + '**/*spring-core*.jar').glob.any?

nebhale · 2017-08-29T13:30:55Z

Any EAR file that contains a WAR using Spring Boot, would do it.

bijukunjummen · 2017-08-29T15:18:22Z

Thanks @nebhale, however then the war in the ear will have to be in an exploded form right for the jars in there to be visible to the buildpack. I will assume that to be the case and try to simulate the issue that @violetagg is seeing

nebhale · 2017-08-29T17:01:37Z

That is correct, and that is how the application we were working with was laid out.

bijukunjummen · 2017-08-29T21:57:31Z

Do you mind providing a sample @nebhale, @violetagg , a sample that I have with a spring boot war packaged in an ear is not starting up at all - https://github.com/bijukunjummen/ear-with-boot, for me to simulate the issue

//cc @kelapure

bijukunjummen · 2017-09-05T20:51:16Z

@violetagg, can you please provide your sample which has this issue.

violetagg · 2017-09-07T16:14:21Z

@bijukunjummen
test-ear.zip

Try with this one. You should be able to see

   2017-09-07T19:12:03.32+0300 [APP/PROC/WEB/0] OUT Caused by: java.lang.ClassNotFoundException: org.springframework.context.ApplicationContextInitializer
   2017-09-07T19:12:03.32+0300 [APP/PROC/WEB/0] OUT 	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
   2017-09-07T19:12:03.32+0300 [APP/PROC/WEB/0] OUT 	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
   2017-09-07T19:12:03.32+0300 [APP/PROC/WEB/0] OUT 	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
   2017-09-07T19:12:03.32+0300 [APP/PROC/WEB/0] OUT 	... 52 more

bijukunjummen · 2017-09-08T22:12:46Z

Awesome, thanks @violetagg, will give this a try and get back to you

bijukunjummen · 2017-09-09T04:37:16Z

I can see only a couple of potential fixes @violetagg, @nebhale , @kelapure

Disable Spring Auto-reconfiguration altogether for ear files.
Add documentation to show how to disable auto-reconfiguration in case of exploded ear files
Copy auto-reconfiguration jars to ALL exploded wars in an ear file and NOT to tomee-lib.

1 and 2 should be very easy, 3 I feel will be tricky since there are now potentially more than 1 target folder. Let me know what you think and I can attempt a fix along those lines.

mgvinuesa · 2018-02-15T15:36:50Z

Hi,

In the issue you talk about a exploded EAR (with the wars "unzipped") but I have a EAR structure similar to this:

sample.ear
|____drivers
| |____driver.jar
|____war1-1.0.war
|____war2-1.0.war
|____lib
  |____ thirdlibrary1.jar
  |____ thirdlibrary2.jar
  |____...
|____META-INF|
 |____application.xml

My wars aren't exploded.

And to provide all the common libs out of the WARs included spring libs the skinnyWars option is enabled in maven plugin. But I have the same error in my logs.

2018-02-15T16:33:04.808+01:00 [APP/PROC/WEB/0] [OUT] Caused by: java.lang.NoClassDefFoundError: org/springframework/context/ApplicationContextInitializer .... 2018-02-15T16:33:04.808+01:00 [APP/PROC/WEB/0] [OUT] Caused by: java.lang.ClassNotFoundException: org.springframework.context.ApplicationContextInitializer

The problem is that I would have to put all the libraries inside the WAR due to if I put only the spring libraries the other libraries won't be able to access to spring classes (classpath hierarchy WAR -> EAR -> tomEE)

mgvinuesa · 2018-02-27T17:05:02Z

Hi @violetagg
Any news about this issue?

violetagg · 2018-03-01T14:21:55Z

Hi,

Can you provide a sample application (with war files that are not exploded)?

Thanks,
Violeta

mgvinuesa · 2018-03-01T15:41:48Z

Yes of course

ear-distribution-0.0.1-SNAPSHOT.ear.zip

I use the following manifest

---
applications:
  - name: BACKEND.TEST
    path: ear-distribution-0.0.1-SNAPSHOT.ear
    memory: 1G

   
#buildpack: https://github.com/cloudfoundry-community/tomee-buildpack#4.9
buildpack: https://github.com/cloudfoundry-community/tomee-buildpack#v4.8

env:
    JBP_LOG_LEVEL: INFO
#    JBP_CONFIG_SPRING_AUTO_RECONFIGURATION: '{ enabled: false }'

To avoid the error I have to disable the AUTO_RECONFIGURATION, in the other hand if you disable it and run the application to can reproduce the error related with the other issue #32 that I have opened making the following GET request:

https://<host>/backend-ssmm-cloud/contrato/

violetagg · 2018-03-05T13:22:01Z

@mgvinuesa Thanks for the sample app. It helped a lot.

In your use case Spring Auto Reconfiguration detects that there are spring framework libraries in the EAR/lib folder and because of this it tries to reconfigure the application.

Do you need the Spring Auto Reconfiguration? If not I would recommend to disable it.

Regards,
Violeta

mgvinuesa · 2018-03-05T15:50:08Z

@violetagg I supposed, same situation that with exploded ears.

Currently I don't need it but maybe in the future, according with what Spring Auto Reconfiguration consists:

it adds the cloud profile to Spring's list of active profiles
it exposes all of the properties contributed by Cloud Foundry as a PropertySource in the ApplicationContext
it re-writes the bean definitions of various types to connect automatically with services bound to the application.

The second one maybe we would need in the future but I suppose that we could get the information manually.

thanks by your support.

bijukunjummen · 2018-03-05T18:27:17Z

Should we do point 2 in #23 (comment) @violetagg , @kelapure, I can attempt a PR

kelapure · 2018-03-05T18:32:17Z

@bijukunjummen - can we explore how to fix this issue with 3 in #23. I feel like just documenting this is not good enough.

violetagg · 2018-03-06T09:18:39Z

Yes I also think that when we have EAR with exploded war files we will be able to provide Spring Auto Reconfiguration.
For EAR where war files are not exploded it will be a bit complicated.

violetagg changed the title ~~Spring Auto Reconfiguration is not operational when the deploying EAR~~ Spring Auto Reconfiguration is not operational when deploying EAR Aug 18, 2017

bijukunjummen added a commit to bijukunjummen/ear-with-boot that referenced this issue Sep 9, 2017

Recreates issue cloudfoundry-community/tomee-buildpack#23

7c5a0f7

nebhale mentioned this issue Jan 18, 2018

EAR failing to start when deployed on PCFDev #30

Closed

mgvinuesa mentioned this issue Mar 1, 2018

TomEE downloaded by buildpack has an incorrect jarsToSkip configuration #32

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spring Auto Reconfiguration is not operational when deploying EAR #23

Spring Auto Reconfiguration is not operational when deploying EAR #23

violetagg commented Aug 18, 2017

violetagg commented Aug 18, 2017

bijukunjummen commented Aug 29, 2017 •

edited

Loading

nebhale commented Aug 29, 2017 •

edited

Loading

bijukunjummen commented Aug 29, 2017

nebhale commented Aug 29, 2017

bijukunjummen commented Aug 29, 2017

bijukunjummen commented Sep 5, 2017

violetagg commented Sep 7, 2017

bijukunjummen commented Sep 8, 2017

bijukunjummen commented Sep 9, 2017

mgvinuesa commented Feb 15, 2018 •

edited

Loading

mgvinuesa commented Feb 27, 2018

violetagg commented Mar 1, 2018

mgvinuesa commented Mar 1, 2018 •

edited

Loading

violetagg commented Mar 5, 2018

mgvinuesa commented Mar 5, 2018

bijukunjummen commented Mar 5, 2018

kelapure commented Mar 5, 2018

violetagg commented Mar 6, 2018

Spring Auto Reconfiguration is not operational when deploying EAR #23

Spring Auto Reconfiguration is not operational when deploying EAR #23

Comments

violetagg commented Aug 18, 2017

violetagg commented Aug 18, 2017

bijukunjummen commented Aug 29, 2017 • edited Loading

nebhale commented Aug 29, 2017 • edited Loading

bijukunjummen commented Aug 29, 2017

nebhale commented Aug 29, 2017

bijukunjummen commented Aug 29, 2017

bijukunjummen commented Sep 5, 2017

violetagg commented Sep 7, 2017

bijukunjummen commented Sep 8, 2017

bijukunjummen commented Sep 9, 2017

mgvinuesa commented Feb 15, 2018 • edited Loading

mgvinuesa commented Feb 27, 2018

violetagg commented Mar 1, 2018

mgvinuesa commented Mar 1, 2018 • edited Loading

violetagg commented Mar 5, 2018

mgvinuesa commented Mar 5, 2018

bijukunjummen commented Mar 5, 2018

kelapure commented Mar 5, 2018

violetagg commented Mar 6, 2018

bijukunjummen commented Aug 29, 2017 •

edited

Loading

nebhale commented Aug 29, 2017 •

edited

Loading

mgvinuesa commented Feb 15, 2018 •

edited

Loading

mgvinuesa commented Mar 1, 2018 •

edited

Loading