Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide way to pass Descending Read option to the Walk command #27

Open
a-b opened this issue Feb 24, 2020 · 1 comment
Open

Provide way to pass Descending Read option to the Walk command #27

a-b opened this issue Feb 24, 2020 · 1 comment

Comments

@a-b
Copy link
Member

a-b commented Feb 24, 2020

While we were working on CLI story, we want to have retry behavior for when we fetch the "MostRecentEnvelope". To do this, we wanted to read envelopes in descending order using the walk function (which currently has retry logic).

We found descending read option not be supported under the current walk function. Current implementation sets the read options explicitly.

As a workaround, we will decorate the client.Read function which is passed to Walk(). We will have it add the descending read option, and get the one envelope we need.

As an alternative approach, we suggest you consider moving retry from Walk to the lower-level Read function.

CC: @bwasmith

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for Changes | Open for Contribution
Development

No branches or pull requests

3 participants