Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt controller-runtime 0.20.0 #3725

Closed
danail-branekov opened this issue Jan 17, 2025 · 1 comment
Closed

Adopt controller-runtime 0.20.0 #3725

danail-branekov opened this issue Jan 17, 2025 · 1 comment
Assignees
Labels

Comments

@danail-branekov
Copy link
Member

danail-branekov commented Jan 17, 2025

controller-runtime 0.20.0 contains a couple of braking changes (webhook: Remove deprecated Defaulter and Validator) which causes compilation to fail

@danail-branekov danail-branekov converted this from a draft issue Jan 17, 2025
@georgethebeatle georgethebeatle moved this from 🇪🇺 To do to 🔄 In progress in Korifi - Backlog Jan 22, 2025
@georgethebeatle georgethebeatle self-assigned this Jan 22, 2025
@uzabanov
Copy link
Contributor

uzabanov commented Jan 22, 2025

We reimplemented all problematic webhooks as cusotom defaulting webhooks. Unfortunately though it turned out that the servicebinding.io dependency has not yet bupmed their controller runtime verion. We have import dependency to servicebinding.io, so we cannot bump controller-runtime before they bump (we are getting similar compilation errors). Getting rid of servicebinding io could be one way to proceed with this bump. Blocking this issue on #1949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants